PHP SDK, needs a quickfix on ProductField class

sybbear · May 4, 2023, 1:16pm

PHP SDK has a bug that renders SDK unusable when fetching product fields with options.
Here is a PR that needs to be reviewed/merged:

github.com/pipedrive/client-php

Type [ProductField->options]: [string|null] -> [array|null]

pipedrive:master ← sybbear:patch-1

opened 12:14PM - 04 May 23 UTC

sybbear

+1 -1

When the options are set and API returns array of options, PHP throws the follow… error: ``` at /vendor/pipedrive/pipedrive/src/Controllers/ProductFieldsController.php:149 24. apimatic\jsonmapper\JsonMapper->map() at /vendor/apimatic/jsonmapper/src/JsonMapper.php:319 25. apimatic\jsonmapper\JsonMapper->mapArray() at /vendor/apimatic/jsonmapper/src/JsonMapper.php:247 26. apimatic\jsonmapper\JsonMapper->map() at /vendor/apimatic/jsonmapper/src/JsonMapper.php:523 27. settype() at /vendor/apimatic/jsonmapper/src/JsonMapper.php:204 28. Illuminate\Exception\Handler->handleError() at : ---- Error Details ---- ErrorException thrown at /vendor/apimatic/jsonmapper/src/JsonMapper.php:204 Array to string conversion ``` This PR sets the correct type and should fix the issue.

Best regards,
Yaroslav

sybbear · May 8, 2023, 6:25am

This is now fixed. Big thanks for the follow-up

Helena_Sul · May 15, 2023, 7:53am

Hi, @sybbear!

Thank you for raising the issue!

Cheers,
Helena